pop-vaud/camarades
Watch
1
0
Fork
You've already forked camarades
 1
Code Issues Pull requests Projects 1 Releases Packages 1 Wiki Activity Actions

Implement payments #8

Merged
wbouzour merged 2 commits from feat/payments into main 2026-10-28 11:23:08 +01:00
Conversation 5 Commits 2 Files changed 25 +1554
yhrel commented 2026-10-27 13:22:53 +01:00
Collaborator
Copy link

Closes #5

Add payment types and payments models
Add manage_payment_types role
Add UI for payment types and payments
Add filter for paid/not paid in the current year for each payment type
Add new translation strings in English only

Closes #5 Add payment types and payments models Add manage_payment_types role Add UI for payment types and payments Add filter for paid/not paid in the current year for each payment type Add new translation strings in English only
yhrel self-assigned this 2026-10-27 13:22:53 +01:00 
Add payment types and payments models
Add manage_payment_types role
Add UI for payment types and payments
Add filter for paid/not paid in the current year for each payment type
Add new translation strings in English only
yhrel removed this from the Intégration JPOP project 2026-10-27 13:23:26 +01:00
wbouzour commented 2026-10-27 18:36:00 +01:00
Owner
Copy link
  • In the payment types UI: could we have something like "Default amount" because it sounds like it's a fixed amount but it's not (Which is good because we don't have fixed amounts in POP).
  • In the member UI: The list of payments only starts showing after we add a payment. Could we make it so it shows even before that?
  • In the search UI: We have a way to filter payments for the current year but no way to filter for the past years. Could we have a second filter for the past years? I'm thinking anything before the current year.
  • Monthly payments: The current system only allows us to create one payment per year. But in POP, some people pay monthly. Is there a way we could allow multiple payments for one year?

Other than that, it looks great. Thank you!

- In the payment types UI: could we have something like "Default amount" because it sounds like it's a fixed amount but it's not (Which is good because we don't have fixed amounts in POP). - In the member UI: The list of payments only starts showing after we add a payment. Could we make it so it shows even before that? - In the search UI: We have a way to filter payments for the current year but no way to filter for the past years. Could we have a second filter for the past years? I'm thinking anything before the current year. - Monthly payments: The current system only allows us to create one payment per year. But in POP, some people pay monthly. Is there a way we could allow multiple payments for one year? Other than that, it looks great. Thank you!
yhrel commented 2026-10-27 18:56:52 +01:00
Author
Collaborator
Copy link
  1. I think it's just a textual change: it's already designed as a "default amount". I'll update the English translation
  2. You mean showing all the missing payments even when none have been recorded ? sure. It was kind of on purpose to not show anything until you add payments to that person
  3. You mean a more complex form where you can choose the year that was paid or not paid (one period at a time) ?
  4. I could simply change the unique rule to allow multiple payments for a year and payment type. Would that suffice ?
1. I think it's just a textual change: it's already designed as a "default amount". I'll update the English translation 2. You mean showing all the missing payments even when none have been recorded ? sure. It was kind of on purpose to not show anything until you add payments to that person 3. You mean a more complex form where you can choose the year that was paid or not paid (one period at a time) ? 4. I could simply change the unique rule to allow multiple payments for a year and payment type. Would that suffice ?
wbouzour commented 2026-10-27 19:05:18 +01:00
Owner
Copy link
  1. That's what I had in mind, thank you.
  2. Yes, everyone has to pay anyway. I think it's just easier to understand for the person managing payments.
  3. No, I just mean a second select field. One for the current year, one for all the past years.
  4. I think so.
1. That's what I had in mind, thank you. 2. Yes, everyone has to pay anyway. I think it's just easier to understand for the person managing payments. 3. No, I just mean a second select field. One for the current year, one for all the past years. 4. I think so.
yhrel commented 2026-10-28 09:51:03 +01:00
Author
Collaborator
Copy link

For 2., that means a field that allows you to find users who paid at least once, excluding current year, or never paid, excluding current year ? I'm not sure I see the use case for this.

For 2., that means a field that allows you to find users who paid at least once, excluding current year, or never paid, excluding current year ? I'm not sure I see the use case for this.
Show all missing payments even when none have been recorded yet
Allow multiple payments per year
Allow filtereing by paid/not paid for any year
yhrel requested review from wbouzour 2026-10-28 10:15:54 +01:00
wbouzour commented 2026-10-28 11:23:03 +01:00
Owner
Copy link

C'est super

C'est super
Sign in to join this conversation.
Reviewers
No reviewers
wbouzour
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
yhrel
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pop-vaud/camarades!8
No description provided.